Coding Standards
Warning: You are browsing the documentation for Symfony 2.x, which is no longer maintained.
Read the updated version of this page for Symfony 7.1 (the current stable version).
Symfony code is contributed by thousands of developers around the world. To make every piece of code look and feel familiar, Symfony defines some coding standards that all contributions must follow.
These Symfony coding standards are based on the PSR-1, PSR-2 and PSR-4 standards, so you may already know most of them.
Making your Code Follow the Coding Standards
Instead of reviewing your code manually, Symfony makes it simple to ensure that your contributed code matches the expected code syntax. First, install the PHP CS Fixer tool and then, run this command to fix any problem:
1 2
$ cd your-project/
$ php php-cs-fixer.phar fix -v
If you forget to run this command and make a pull request with any syntax issue, our automated tools will warn you about that and will provide the solution.
Symfony Coding Standards in Detail
If you want to learn about the Symfony coding standards in detail, here's a short example containing most features described below:
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103
<?php
/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Acme;
/**
* Coding standards demonstration.
*/
class FooBar
{
const SOME_CONST = 42;
/**
* @var string
*/
private $fooBar;
/**
* @param string $dummy Some argument description
*/
public function __construct($dummy)
{
$this->fooBar = $this->transformText($dummy);
}
/**
* @return string
*
* @deprecated
*/
public function someDeprecatedMethod()
{
@trigger_error(sprintf('The %s() method is deprecated since version 2.8 and will be removed in 3.0. Use Acme\Baz::someMethod() instead.', __METHOD__), E_USER_DEPRECATED);
return Baz::someMethod();
}
/**
* Transforms the input given as first argument.
*
* @param bool|string $dummy Some argument description
* @param array $options An options collection to be used within the transformation
*
* @return string|null The transformed input
*
* @throws \RuntimeException When an invalid option is provided
*/
private function transformText($dummy, array $options = array())
{
$defaultOptions = array(
'some_default' => 'values',
'another_default' => 'more values',
);
foreach ($options as $option) {
if (!in_array($option, $defaultOptions)) {
throw new \RuntimeException(sprintf('Unrecognized option "%s"', $option));
}
}
$mergedOptions = array_merge(
$defaultOptions,
$options
);
if (true === $dummy) {
return null;
}
if ('string' === $dummy) {
if ('values' === $mergedOptions['some_default']) {
return substr($dummy, 0, 5);
}
return ucwords($dummy);
}
}
/**
* Performs some basic check for a given value.
*
* @param mixed $value Some value to check against
* @param bool $theSwitch Some switch to control the method's flow
*
* @return bool|void The resultant check if $theSwitch isn't false, void otherwise
*/
private function reverseBoolean($value = null, $theSwitch = false)
{
if (!$theSwitch) {
return;
}
return !$value;
}
}
Structure
- Add a single space after each comma delimiter;
- Add a single space around binary operators (
==
,&&
, ...), with the exception of the concatenation (.
) operator; - Place unary operators (
!
,--
, ...) adjacent to the affected variable; - Always use identical comparison unless you need type juggling;
- Use Yoda conditions when checking a variable against an expression to avoid
an accidental assignment inside the condition statement (this applies to
==
,!=
,===
, and!==
); - Add a comma after each array item in a multi-line array, even after the last one;
- Add a blank line before
return
statements, unless the return is alone inside a statement-group (like anif
statement); - Use
return null;
when a function explicitly returnsnull
values and usereturn;
when the function returnsvoid
values; - Use braces to indicate control structure body regardless of the number of statements it contains;
- Define one class per file - this does not apply to private helper classes that are not intended to be instantiated from the outside and thus are not concerned by the PSR-0 and PSR-4 autoload standards;
- Declare the class inheritance and all the implemented interfaces on the same line as the class name;
- Declare class properties before methods;
- Declare public methods first, then protected ones and finally private ones.
The exceptions to this rule are the class constructor and the
setUp()
andtearDown()
methods of PHPUnit tests, which must always be the first methods to increase readability; - Declare all the arguments on the same line as the method/function name, no matter how many arguments there are;
- Use parentheses when instantiating classes regardless of the number of arguments the constructor has;
- Exception and error message strings must be concatenated using sprintf;
- Calls to trigger_error with type
E_USER_DEPRECATED
must be switched to opt-in via@
operator. Read more at Conventions; - Do not use
else
,elseif
,break
afterif
andcase
conditions which return or throw something; - Do not use spaces around
[
offset accessor and before]
offset accessor; - Add a
use
statement for every class that is not part of the global namespace; - When PHPDoc tags like
@param
or@return
includenull
and other types, always placenull
at the end of the list of types.
Naming Conventions
- Use camelCase for PHP variables, function and method names, arguments
(e.g.
$acceptableContentTypes
,hasSession()
); - Use snake_case for configuration parameters and Twig template variables
(e.g.
framework.csrf_protection
,http_status_code
); - Use namespaces for all PHP classes and UpperCamelCase for their names (e.g.
ConsoleLogger
); - Prefix all abstract classes with
Abstract
except PHPUnit*TestCase
. Please note some early Symfony classes do not follow this convention and have not been renamed for backward compatibility reasons. However all new abstract classes must follow this naming convention; - Suffix interfaces with
Interface
; - Suffix traits with
Trait
; - Suffix exceptions with
Exception
; - Use UpperCamelCase for naming PHP files (e.g.
EnvVarProcessor.php
) and snake case for naming Twig templates and web assets (section_layout.html.twig
,index.scss
); - For type-hinting in PHPDocs and casting, use
bool
(instead ofboolean
orBoolean
),int
(instead ofinteger
),float
(instead ofdouble
orreal
); - Don't forget to look at the more verbose Conventions document for more subjective naming considerations.
Service Naming Conventions
- A service name contains groups, separated by dots;
- The DI alias of the bundle is the first group (e.g.
fos_user
); - Use lowercase letters for service and parameter names;
- A group name uses the underscore notation.
Documentation
- Add PHPDoc blocks for all classes, methods, and functions (though you may be asked to remove PHPDoc that do not add value);
- Group annotations together so that annotations of the same type immediately follow each other, and annotations of a different type are separated by a single blank line;
- Omit the
@return
tag if the method does not return anything; - The
@package
and@subpackage
annotations are not used; - Don't inline PHPDoc blocks, even when they contain just one tag (e.g. don't
put
/** {@inheritdoc} */
in a single line); - When adding a new class or when making significant changes to an existing class,
an
@author
tag with personal contact information may be added, or expanded. Please note it is possible to have the personal contact information updated or removed per request to the doc:`core team </contributing/code/core_team>`.
License
- Symfony is released under the MIT license, and the license block has to be present at the top of every PHP file, before the namespace.