Archives


Master Symfony2 fundamentals

Be trained by SensioLabs experts (2 to 6 day sessions -- French or English).
trainings.sensiolabs.com

Discover the SensioLabs Support

Access to the SensioLabs Competency Center for an exclusive and tailor-made support on Symfony
sensiolabs.com

Fabien Potencier
Introducing a new Review Tool for the Symfony ecosystem
by Fabien Potencier – April 01, 2012 – 18 comments

During the last few weeks, we have worked hard creating a new review tool for the Symfony ecosystem, ismypullrequeststoffedyet. This tool is incredible fast and it needs less memory than any other comparable quality assurance product, saving you the trouble of setting up continuous integration servers or any other so-called quality assurance sofware.

Requirements

Any Symfony-related Open-Source project managed in a public repository on GitHub.

How does it work?

Whenever you want to add a new feature or fix a bug on any Symfony-related software, follow these few simple steps:

  • Test your code and assure the correctness of it;

  • Create a pull request on GitHub as usual;

  • Our tool will recognize this pull request and analyse its code within seconds. Yes, seconds! When this process is done the result will be added as a comment in your pull request in a process known to experienced developers as stoffing. Your pull request will be tagged green (a.k.a stoffed) on our website.

  • Later, a project member takes this pull request and, before merging, checks on the tool website if the PR is already stoffed. If yes, he will merge your pull request without having to worry about possible code breaks or other related issues.

Thanks Pierre Minnieur for having created this awesome tool. It will help us improve Symfony and all related software at a much faster pace!

Comments RSS

  • Hugo Hamon
    #1 Hugo Hamon said on the 2012/04/01 at 15:20
    Awesome! Symfony community really needs such a tool for QA :)
  • Alexander Orabey
    #2 Alexander Orabey said on the 2012/04/01 at 15:23
    Yeeaap! Thks)
  • Michel Salib
    #3 Michel Salib said on the 2012/04/01 at 15:25
    Really ?! oO
    I love it !
  • Christophe Coevoet
    #4 Christophe Coevoet said on the 2012/04/01 at 15:31
    Many repositories are missing in the tool.The complete list should be taken from https://github.com/stof/following
    The reporting could be improved too: PRs are marked as green as soon as a review is done, even when the review is asking for changes or saying that the PR is breaking the code entirely (see #3751 on the symfony repo for instance)

    And will SensioLabs pay me for providing this tool ? I would love it :)
  • Fabien Potencier
    #5 Fabien Potencier said on the 2012/04/01 at 15:32
    Some people are already asking if we are going to open-source this tool, including the awesome underlying @stof70 technology... Well, we are of course thinking about this too!
  • Fabien Potencier
    #6 Fabien Potencier said on the 2012/04/01 at 15:33
    @Christophe: Actually, I would love to pay for such a technology. Just contact me...
  • Pierre Minnieur
    #7 Pierre Minnieur said on the 2012/04/01 at 16:51
    thanks for your tips stof, I'll take care of them with the next iteration. For the start I just cherry picked the most common and related repositories for the symfony-standard edition ;-)
  • Félix-Antoine Paradis
    #8 Félix-Antoine Paradis said on the 2012/04/01 at 17:28
    You should also enhance the IRC bot... sometimes, it is not available during Asian work hours... Coverage for Europe/America is great tho.
  • Christophe Coevoet
    #9 Christophe Coevoet said on the 2012/04/01 at 18:01
    @felix the IRC bot is not perfect and requires some downtime every day (the PR review system is down at the same time so reviews are delayed). Sorry about that :)
  • Marco Pivetta
    #10 Marco Pivetta said on the 2012/04/01 at 18:06
    Is there already some ideas about multitasking? Could the process be forked off? Maybe a StofFactory :D
  • Christophe Coevoet
    #11 Christophe Coevoet said on the 2012/04/01 at 22:32
    @Marco sorry, it has been designed as a singleton (I'm not responsible for it)
  • Mohammad Forouzani
    #12 Mohammad Forouzani said on the 2012/04/01 at 23:55
    Stoff powered QA?

    I wish! Im quite sure a lot of companies would pay for such a tool ;)
  • cateland axel
    #13 cateland axel said on the 2012/04/02 at 06:26
    Nice one !
  • Sebastien GOSSELET
    #14 Sebastien GOSSELET said on the 2012/04/02 at 09:03
    Excellent !
  • Jordan Stout
    #15 Jordan Stout said on the 2012/04/02 at 19:17
    Is the name of it an April fools joke? ;p
  • Peter Kokot
    #16 Peter Kokot said on the 2012/04/03 at 18:30
    Amazing. That is really awesome. Thank you.
  • Loïc Vernet
    #17 Loïc Vernet said on the 2012/04/04 at 23:19
    Cool, my PR is stoffed ! ^^
  • Marc Weistroff
    #18 Marc Weistroff said on the 2012/04/06 at 08:51
    :D