Community Reviews

Why Reviewing Is Important

Community reviews are essential for the development of the Symfony framework, since there are many more pull requests and bug reports than there are members in the Symfony core team to review, fix and merge them.

On the Symfony issue tracker, you can find many items in a Needs Review status:

• Bug Reports: Bug reports need to be checked for completeness. Is any important information missing? Can the bug be reproduced?
• Pull Requests: Pull requests contain code that fixes a bug or implements new functionality. Reviews of pull requests ensure that they are implemented properly, are covered by test cases, don't introduce new bugs and maintain backward compatibility.

Note that anyone who has some basic familiarity with Symfony and PHP can review bug reports and pull requests. You don't need to be an expert to help.

Be Constructive

Before you begin, remember that you are looking at the result of someone else's hard work. A good review comment thanks the contributor for their work, identifies what was done well, identifies what should be improved and suggests a next step.

Create a GitHub Account

Symfony uses GitHub to manage bug reports and pull requests. If you want to do reviews, you need to create a GitHub account and log in.

The Bug Report Review Process

A good way to get started with reviewing is to pick a bug report from the bug reports in need of review.

The steps for the review are:

1. Is the Report Complete?

   Good bug reports contain a link to a fork of the Symfony Standard Edition (the "reproduction project") that reproduces the bug. If it doesn't, the report should at least contain enough information and code samples to reproduce the bug.

2. Reproduce the Bug

   Download the reproduction project and test whether the bug can be reproduced on your system. If the reporter did not provide a reproduction project, create one by forking the Symfony Standard Edition.

3. Update the Issue Status

   At last, add a comment to the bug report. Thank the reporter for reporting the bug. Include the line Status: <status> in your comment to trigger our Carson Bot which updates the status label of the issue. You can set the status to one of the following:

   Needs Work If the bug does not contain enough information to be reproduced, explain what information is missing and move the report to this status.

   Works for me If the bug does contain enough information to be reproduced but works on your system, or if the reported bug is a feature and not a bug, provide a short explanation and move the report to this status.

   Reviewed If you can reproduce the bug, move the report to this status. If you created a reproduction project, include the link to the project in your comment.

1
2
3
4
5

Thank you @weaverryan for creating this bug report! This indeed looks
like a bug. I reproduced the bug in the "kernel-bug" branch of
https://github.com/webmozart/symfony-standard.

Status: Reviewed

The Pull Request Review Process

The process for reviewing pull requests (PRs) is similar to the one for bug reports. Reviews of pull requests usually take a little longer since you need to understand the functionality that has been fixed or added and find out whether the implementation is complete.

It is okay to do partial reviews! If you do a partial review, comment how far you got and leave the PR in "Needs Review" state.

Pick a pull request from the PRs in need of review and follow these steps:

1. Is the PR Complete?

   Every pull request must contain a header that gives some basic information about the PR. You can find the template for that header in the Contribution Guidelines.

2. Is the Base Branch Correct?

   GitHub displays the branch that a PR is based on below the title of the pull request. Is that branch correct?

   • Bugs should be fixed in the oldest, maintained version that contains the bug. Check Symfony's Release Schedule to find the oldest currently supported version.
   • New features should always be added to the current development version. Check the Symfony Roadmap to find the current development version.

3. Reproduce the Problem

   Read the issue that the pull request is supposed to fix. Reproduce the problem on a clean Symfony Standard Edition project and try to understand why it exists. If the linked issue already contains such a project, install it and run it on your system.

4. Review the Code

   Read the code of the pull request and check it against some common criteria:

   • Does the code address the issue the PR is intended to fix/implement?
   • Does the PR stay within scope to address only that issue?
   • Does the PR contain automated tests? Do those tests cover all relevant edge cases?
   • Does the PR contain sufficient comments to understand its code?
   • Does the code break backward compatibility? If yes, does the PR header say so?
   • Does the PR contain deprecations? If yes, does the PR header say so? Does the code contain trigger_error() statements for all deprecated features?
   • Are all deprecations and backward compatibility breaks documented in the latest UPGRADE-X.X.md file? Do those explanations contain "Before"/"After" examples with clear upgrade instructions?

   Note

   Eventually, some of these aspects will be checked automatically.

5. Test the Code

   Take your project from step 3 and test whether the PR works properly. Replace the Symfony project in the vendor directory by the code in the PR by running the following Git commands. Insert the PR ID (that's the number after the # in the PR title) for the <ID> placeholders:

   1
   2
   3

   $ cd vendor/symfony/symfony
   $ git fetch origin pull/<ID>/head:pr<ID>
   $ git checkout pr<ID>

   For example:

   1
   2

   $ git fetch origin pull/15723/head:pr15723
   $ git checkout pr15723

   Now you can test the project against the code in the PR.

6. Update the PR Status

   At last, add a comment to the PR. Thank the contributor for working on the PR. Include the line Status: <status> in your comment to trigger our Carson Bot which updates the status label of the issue. You can set the status to one of the following:

   Needs Work If the PR is not yet ready to be merged, explain the issues that you found and move it to this status.

   Reviewed If the PR satisfies all the checks above, move it to this status. A core contributor will soon look at the PR and decide whether it can be merged or needs further work.

1
2
3
4
5

Thank you @weaverryan for working on this! It seems that your test
cases don't cover the cases when the counter is zero or smaller.
Could you please add some tests for that?

Status: Needs Work